beanz added inline comments.
================ Comment at: clang/lib/Basic/Targets/DirectX.h:66 + bool hasBitIntType() const override { return true; } bool hasFeature(StringRef Feature) const override { ---------------- aaron.ballman wrote: > This change requires more testing/thought, IMO -- do you support 128-bit > operations? When we bump that limit to be arbitrarily high, should DX have > the arbitrary limits or do you need to enforce something lower? Have you > considered how you want to pack these into structures or other data layout > considerations? Yea, we definitely need to set the max width to 64 for DirectX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits