iains planned changes to this revision. iains added a comment. So, in light of these comments;
- It seems that there is one case where I //can// elide the guard - where the init is completely empty (including of calls to imported module inits) - otherwise, I need to investigate what is needed for an importee to communicate that it has an empty init and thus does not need to be called. I think the first of these could be useful in quite a few cases (it's not clear to me at this relatively early stage in modules adoption that we see very deep include graphs - but somewhat unknown). The second will have to live on the TODO for now (at least from me). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134589/new/ https://reviews.llvm.org/D134589 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
