mizvekov added a comment.

In D134604#3814986 <https://reviews.llvm.org/D134604#3814986>, @ldionne wrote:

> As explained in more details here 
> (https://reviews.llvm.org/D133249#inline-1289205), it would be nice to stop 
> using the `DELETE.ME` idiom to kick off libc++ CI, unless you really think 
> there's a good chance to cause failures in libc++ specifically.
>
> TLDR of the link: the libc++ CI has 50+ jobs, exactly one of which will 
> exercise your Clang changes. All the other jobs are using pre-compiled 
> versions of Clang. So in reality, this `DELETE.ME` file trick only results in 
> wasting libc++ CI resources, in addition to adding the libc++ review group on 
> reviews that we probably don't need to look at. If you do suspect that the 
> change might break libc++ specifically (such as changing diagnostics or 
> whatever), then you're welcome to do so, although in the mid-term we'll try 
> to simply run the libc++ tests as part of Clang's own CI setup.

Hello!

I was aware of those discussions, and I even made a workaround to avoid this 
extra cost of running unrelated pipelines.
The patch on the very top of this stack (D134079 
<https://reviews.llvm.org/D134079>) disables all the other pipelines except the 
bootstrapping one.

For this patch, I only needed a pipeline run for the initial submission, but I 
don't  plan to keep running it, I will remove the `DELETE.ME` on the next 
submission.

I have two other patches in the stack which I will need to keep running the 
libcxx-ci as I update them: D131858 <https://reviews.llvm.org/D131858> and 
D127695 <https://reviews.llvm.org/D127695>. These have had non-trivial libcxx 
breakages, and I have even seen new problems introduced as you keep working on 
the ranges implementation.

Thanks by the way for the awesome work on the libcxx-CI, and I hope in the near 
future these workarounds will not be needed anymore!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134604/new/

https://reviews.llvm.org/D134604

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to