craig.topper added inline comments.
================ Comment at: llvm/test/MC/RISCV/rv32zcmt-Invalid.s:5 +# CHECK-ERROR: error: immediate must be an integer in the range [0, 63] +cm.jt 64 ---------------- Why no invalid test for cm.jalt? ================ Comment at: llvm/test/MC/RISCV/rv32zcmt-valid.s:8 +# RUN: -M no-aliases -d -r - \ +# RUN: | FileCheck --check-prefixes=CHECK-OBJ,CHECK-ASM-AND-OBJ %s + ---------------- What about CHECK-NO-EXT like other tests have? ================ Comment at: llvm/test/MC/RISCV/rv64zcmt-Invalid.s:1 +# RUN: not llvm-mc -triple=riscv64 -mattr=+experimental-zcmt -riscv-no-aliases -show-encoding < %s 2>&1 \ +# RUN: | FileCheck -check-prefixes=CHECK-ERROR %s ---------------- Why is Invalid capitalized in this test name. It isn't capitalized in other MC tests is it? ================ Comment at: llvm/test/MC/RISCV/rv64zcmt-Invalid.s:1 +# RUN: not llvm-mc -triple=riscv64 -mattr=+experimental-zcmt -riscv-no-aliases -show-encoding < %s 2>&1 \ +# RUN: | FileCheck -check-prefixes=CHECK-ERROR %s ---------------- craig.topper wrote: > Why is Invalid capitalized in this test name. It isn't capitalized in other > MC tests is it? Merge this with the rv32 test. ================ Comment at: llvm/test/MC/RISCV/rv64zcmt-valid.s:1 +# RUN: llvm-mc %s -triple=riscv64 -mattr=+experimental-zcmt\ +# RUN: -riscv-no-aliases -show-encoding \ ---------------- Merge this with rv32zcmt-valid.s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
