nickdesaulniers added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:376
+ if (getTriple().isMIPS()) {
+ const Multilib &Multilib = GCCInstallation.getMultilib();
+ Path = Path + "/libc" + Multilib.osSuffix();
----------------
nickdesaulniers wrote:
> It might be worthwhile to have the variable be
> ```
> std::string OSSuffix = GCCInstallation.getMultilib().osSuffix();
> ```
> rather than the `Multilib` object.
err... I guess a `std::string&`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134454/new/
https://reviews.llvm.org/D134454
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
