tbaeder added a comment. In D134958#3827024 <https://reviews.llvm.org/D134958#3827024>, @erichkeane wrote:
> This seems right enough to me, though you might consider CTZ as well since > it is equally as easy. A better/more useful attempt is going to be > builtin_strlen. Note that with builtins they are going to be particularly > difficult because you can't execute them on the local machine, since we have > to give the same result as the target machine. Integer sizes can be a > problem for that, but a lot of the builtins work differently based on which > target you're running on. Hmm, I see. Do you know of any existing tests in the clang code base that exercise those differences? ================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:954 + assert(*T); + FuncDecl->dump(); + ---------------- erichkeane wrote: > Whats happening here? Is this leftover debugging code? Oh, yep! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134958/new/ https://reviews.llvm.org/D134958 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
