serge-sans-paille added a comment. In D134791#3827722 <https://reviews.llvm.org/D134791#3827722>, @msebor wrote:
> Thanks for the heads up! My only general comment is that unless this change > has no externally observable effect I'd suggest adding tests. (Otherwise, > noting it has no such effect would be helpful.) When I'm not familiar with > the code (and often even what I am) I usually look for tests to understand > the impact of a change. Agredd! This change should only be a refactoring one, but I can see edge cases where it brings some subtle difference (e.g. for `ObjCIvarRefExpr` but I need to explore that. Will do!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134791/new/ https://reviews.llvm.org/D134791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
