MaskRay added a comment.

In D135076#3831371 <https://reviews.llvm.org/D135076#3831371>, @jhuber6 wrote:

> In D135076#3831363 <https://reviews.llvm.org/D135076#3831363>, @MaskRay wrote:
>
>> My idea is to just disallow `Joined` `-o` when targeting a specific 
>> environment (e.g. when offloading toolchain is used).
>
> This seems difficult as we only know which offloading toolchains are active 
> after we fully construct the `Compilation` in the driver. We could 
> potentially re-parse some options afterwards to do some static checks like 
> this.

I think I'm fine if you want to warning for every Joined `-o` use of 
`ffloading-*`. Created D135093 <https://reviews.llvm.org/D135093> to revert 
this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135076/new/

https://reviews.llvm.org/D135076

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to