rjmccall added a comment.

The titled of this patch should be something like "Add 
__builtin_elementwise_sin and __builtin_elementwise_cos".

Can you explain why this uses a new builtin name instead of overloading the 
existing builtins to work on vectors?  I can imagine reasons why, but I think 
it needs to be explained.  I can't imagine `cos` and `sin` not being 
element-wise operations on a vector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135011/new/

https://reviews.llvm.org/D135011

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to