efriedma added a comment.

I think we want to test both that the warning isn't triggered when --target 
isn't specified, and that the warning is triggered when --target is specified.



================
Comment at: clang/test/Driver/cl-options.c:787
+// ARM64EC: "-triple" "arm64ec-pc-windows-msvc19.20.0"
+// ARM64EC-NOT: /arm64EC has been overridden by specified target
+
----------------
I think the ARM64EC-NOT might be in the wrong place?  I think the warning would 
show up before the final command line, not after it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134788/new/

https://reviews.llvm.org/D134788

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to