tra added inline comments.

================
Comment at: clang/lib/CodeGen/CGExpr.cpp:1792
     // attach range metadata to the load.
-  } else if (CGM.getCodeGenOpts().OptimizationLevel > 0)
+    // TODO: Enable range metadata for AMDGCN after backend issue is fixed.
+  } else if (CGM.getCodeGenOpts().OptimizationLevel > 0 &&
----------------
It would be great to open a github issue, if we don't have one yet, and 
reference it here, so we can tell later what exactly it is we're working around 
here and know for sure when/whether we can undo the change.


================
Comment at: clang/test/CodeGenCUDA/bool-range.cu:14
+// range metadata is not emitted.
+// TODO: Re-enable range metadata after backend issue is fixed.
+
----------------
Ditto, a bug reference would help.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135269/new/

https://reviews.llvm.org/D135269

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to