aaron.ballman added a comment. In D134456#3827661 <https://reviews.llvm.org/D134456#3827661>, @aaron.ballman wrote:
> Thank you (everyone!) for the discussion on this. To make sure we're all on > the same page for where we're at: > > 1. The changes in this review are reasonable and once review is finished, > we're clear to land it. > 2. We should file an issue to track the feature request for adding opt > remarks for likelihood attribute disagreements. I filed https://github.com/llvm/llvm-project/issues/58187 for this. > 3. We should file a bug to improve the PGO documentation > (https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization) to > explicitly document our behavior around explicitly-provided user annotations > that disagree with PGO (this goes beyond `[[likely]]` and into things like > `__builtin_expect`, `inline`, etc). I filed https://github.com/llvm/llvm-project/issues/58189 for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
