Prazek added a comment.

Is it in upstream yet?


================
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.h:19
@@ +18,3 @@
+
+/// Flags slicing of member variables or vtable. See:
+///   -
----------------
courbet wrote:
> Prazek wrote:
> > some short description what does this check do?
> There is already a more detialed explanation provided in 
> extra/clang-tidy/checks/cppcoreguidelines-slicing.html, and I feel that the 
> links explain it better than anything short we could put in the comments 
> there. Or should I copy-paste what's in 
> extra/clang-tidy/checks/cppcoreguidelines-slicing.html ?
Well, it would be good to at least say what is slicing :)


https://reviews.llvm.org/D21992



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to