davrec accepted this revision.
davrec added a comment.
Looks good, over to @ChuanqiXu
================
Comment at: clang/include/clang/Sema/Template.h:80
+ struct ArgumentListLevel {
+ Decl *AssociatedDecl;
+ ArgList Args;
----------------
mizvekov wrote:
> davrec wrote:
> > mizvekov wrote:
> > > davrec wrote:
> > > > Actually I think this one should be changed back to `ReplacedDecl` :)
> > > > ReplacedDecl makes perfect sense in MLTAL, AssociatedDecl seems to make
> > > > better sense in STTPT.
> > > I would be against introducing another term to refer to the same thing...
> > The reason we need this unfortunately vague term "AssociatedDecl" in STTPT
> > is because it can either be a template/template-like declaration *or* a
> > TemplateTypeParmDecl. But here in MLTAL, it won't be a TTPD, will it? It
> > will always be the parent template/template-like declaration, right? So
> > there is no need for vagueness. `ReplacedDecl` or `ParentTemplate` or
> > something like that seems more appropriate.
> No, it can be the TTPD which is used to represent the invented template for a
> requires substitution.
K, makes sense to keep it the same then
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131858/new/
https://reviews.llvm.org/D131858
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
