void added a comment. In D135989#3859763 <https://reviews.llvm.org/D135989#3859763>, @nickdesaulniers wrote:
> LGTM; please consider appending to the commit message something along the > lines of "operations on the result of getTypeSize() are in bits, not bytes. > Using 1 as the value for void* is the correct number of bytes, but we're > doing arithmetic in bits." or something to denote this is a unit-of-measure > related bug. Done. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135989/new/ https://reviews.llvm.org/D135989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
