Trass3r added a comment.

In D135690#3862112 <https://reviews.llvm.org/D135690#3862112>, @aaron.ballman 
wrote:

> Pretty sure that was after `/Zc:inline` (IIRC that existed in MSVC 2015 which 
> was roughly when I recall we were hitting this).

I see, yeah `/Zc:inline` got added slightly earlier:
https://github.com/llvm/llvm-project/commit/f846557eb89a913c69b54653b9bece04b0473233
than `/bigobj`:
https://github.com/llvm/llvm-project/commit/969b1a50a04e579146f1a78c0c10547a8175577c

> The two examples you found do look like plausible reasons to expose this 
> matcher though. Would you mind proving that out by switching those over to 
> use the new matcher (as a second patch building on top of this one)? If it 
> looks like we can easily use the new matcher in those checks, then I think 
> it's a good enough reason to add the matcher (and update those checks).

Ok 👍


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135690/new/

https://reviews.llvm.org/D135690

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to