jkorous added a comment.
Thank you for the patch!
================
Comment at: clang/test/SemaCXX/references.cpp:93
-struct C : B, A { }; // expected-warning {{direct base 'A' is inaccessible due
to ambiguity:\n struct C -> struct B -> struct A\nstruct C -> struct A}}
+struct C : B, A { }; // expected-warning {{direct base 'A' is inaccessible due
to ambiguity:\n struct C -> struct B -> struct A\n struct C -> struct A}}
----------------
Can you please explain in detail what bug are you fixing?
In my understanding if we stop parsing after the last newline then the existing
test would have failed. The difference seems to be only the white-space.
Am I missing something?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126908/new/
https://reviews.llvm.org/D126908
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
