ychen added a comment. In D136545#3877899 <https://reviews.llvm.org/D136545#3877899>, @royjacobson wrote:
> LGTM, thanks for picking it up! I wonder how much effect this has on > compilation times given that `SubsumptionCache` caches subsumption by the > `Decl *` pair... It seems neutral https://llvm-compile-time-tracker.com/compare.php?from=0ec6373e29f4c129490abef9d38015e9ec0b10ce&to=060fafdcf819578b89505c73d3235e44f56caa60&stat=instructions > One Q - do you think that adding an assert to IsAtLeastAsConstrained to not > accept 'instantiated' functions/structs again is possible somehow? Great idea. For sure. I added the assertion and found two more places needing updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136545/new/ https://reviews.llvm.org/D136545 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
