TIFitis marked 2 inline comments as done.
TIFitis added inline comments.
================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4712
+ Module &M, OffloadEntriesInfoManager &OffloadEntriesInfoManager,
+ bool isDevice) {
+ // If we are in target mode, load the metadata from the host IR. This code
has
----------------
jsjodin wrote:
> isDevice must be true (add assertion at the call site) remove the parameter,
> and the assertions in this function. Document that this function is only
> intended to be used with device code generation.
I've removed isDevice as a parameter. At the call site, isDevice is checked
inside an if condition and it returns on false, thus I haven't added the
assertion back at the call site.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136872/new/
https://reviews.llvm.org/D136872
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
