nickdesaulniers added inline comments.
================ Comment at: clang/lib/CodeGen/CGStmt.cpp:2362 + // a pointer. + if (TruncTy->isFloatingPointTy()) + Tmp = Builder.CreateFPTrunc(Tmp, TruncTy); ---------------- nickdesaulniers wrote: > void wrote: > > This looks like a direct copy from below (which is fine). I'm a bit iffy on > > whether this covers *all* of the value types that could come through here... > Note: this code was simply moved wholesale. If value types are missing, that > is a pre-existing bug and should be a prerequisite to fix for this patch. > > I've broken out D137113 as a child patch to make that clearer. s/should/shouldn't/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
