v.g.vassilev marked an inline comment as not done. v.g.vassilev added a comment.
In D127284#3902487 <https://reviews.llvm.org/D127284#3902487>, @aaron.ballman wrote: > It looks like precommit CI caught a relevant issue that should be addressed. Yes, I have a comment (starting with "The only remaining failure is in test/Parser/cxx-class.cpp where we have something similar to") asking for help. I have accidentally marked it as resolved but it is not. I will spend some time tomorrow trying to figure out what's the best way forward. > Also, there's an in-progress patch that might be worth keeping an eye on in > case it changes the behavior for clang-repl in bad ways: > https://reviews.llvm.org/D137020 -- the patch causes unknown declaration > specifiers to be parsed as if they were a type specifier rather than an > expression, which could potentially change repl behavior. Thanks for the heads up! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits