hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The current patch looks good from my side. There is a remaining discussion
around the verbosity of unittests, but I think we should not be blocked by that.
================
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:57
+struct SymbolReference {
+ /// The locaiton in which the reference happened.
+ SourceLocation Loc;
----------------
nit: locaition => location.
================
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:61
+ Symbol Target;
+ /// The reason the edge was formed.
+ RefType RT;
----------------
what's is the edge? I understand it in some degree, but I'd avoid introducing
new concept as it might lead to some confusions (and we haven't defined a
graph anywhere in the code).
================
Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:24
+#include "clang-include-cleaner/Analysis.h" // FIXME: Move RefType into a
separate header.
#include "clang/Basic/SourceLocation.h"
----------------
this is out-of-date, I think, the RefType is in Types.h.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135859/new/
https://reviews.llvm.org/D135859
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
