FreddyYe added inline comments.
================ Comment at: llvm/include/llvm/Support/X86TargetParser.def:94 +X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4, "znver4") +X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST, "sierraforest") +X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS, "graniterapids") ---------------- pengfei wrote: > FreddyYe wrote: > > FreddyYe wrote: > > > FYI: gcc is going to land the [[ > > > https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603547.html | > > > sierraforest patch ]]. They are going to add such E-core based CPUs to > > > CPU_TYPE list but not this one, like the previous atom series e.g. > > > tremont, silvermont and so on. It's functionally correct, so I'm ok to > > > this change. WDYT > > > FYI: gcc is going to land the [[ > > > https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603547.html | > > > sierraforest patch ]]. They are going to add such E-core based CPUs to > > > CPU_TYPE list but not this one, like the previous atom series e.g. > > > tremont, silvermont and so on. It's functionally correct, so I'm ok to > > > this change. WDYT > > > > ping. > Is this to match with GCC? Yes. ================ Comment at: llvm/lib/Target/X86/X86.td:949 + FeatureAMXINT8, + FeatureAMXBF16, + FeatureBF16]; ---------------- skan wrote: > Why is this differnt from FeaturesGraniteRapids in X86TargetParser.cpp? Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
