tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
lgtm, thanks! One small suggestion below.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:988
if (CodeGenOpts.PrepareForThinLTO && !CodeGenOpts.DisableLLVMPasses) {
if (!CodeGenOpts.ThinLinkBitcodeFile.empty()) {
ThinLinkOS = openOutputFile(CodeGenOpts.ThinLinkBitcodeFile);
----------------
I'd go ahead and move this extra file emission under the EmitBC case, since it
is also a BC file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137768/new/
https://reviews.llvm.org/D137768
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
