mstorsjo added a comment. In https://reviews.llvm.org/D22857#497719, @rengolin wrote:
> I'll just echo @compnerd comments, since Phab didn't get it. > > - Change the syntax to __asm__, to be more portable > - Add Microsoft asm block syntax MSVC doesn't support inline assembly on ARM at all (they only support that on 32 bit x86), so there's none of their syntax to support or test. In https://reviews.llvm.org/D22857#497808, @rengolin wrote: > As I read it, this is just making sure "inline asm" works on Windows, which > apparently hasn't been working so far. In a way, unrelated to the commit in > question. No, inline assembly has been working, but only for assembly that didn't contain any immediate values. > I agree we shouldn't be adding clang tests to assembler bugs. Ok, we can skip this test if you prefer - the assembler test added for llvm-mc should be fine and enough as well. https://reviews.llvm.org/D22857 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
