pratlucas added inline comments.
================ Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH("armv9-a", ARMV9A, "9-A", "v9a", ---------------- stuij wrote: > tmatheson wrote: > > No ARM::AEK_SHA2 | ARM::AEK_AES? Or does 8.8 need updated? > Yes, I think 8.8 needs update, and some other arches as well. > > In the A profile armarm, section A2.3, it is stated that from 8.2 SME(2) and > EAS aren't by default included in the cryptographic extension as the > Cryptographic Extension in an implementation is subject to export license > controls. Inclusion of the extension can be either/or or none, so we should > default to none. > > I think this should be handled by separate patch. The v8.9-a entry on AArch64TargetParser.def includes both `AEK_SHA2` and `AEK_AES`. Can you also update it to make sure they are consistent? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits