hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:112
+ // double' mode.
+ static SmallDenseMap<unsigned, StringRef, 4> AIXLongDoubleBuiltins{
+ {Builtin::BI__builtin_frexpl, "frexp"},
----------------
Please rename to "AIXLongDouble64Builtins".
================
Comment at: clang/test/CodeGen/aix-builtin-mapping.c:3
+// 'long double'. Check that the compiler generates calls to the 'double'
+// versions for correspoding builtin functions in 64-bit 'long double' mode.
+
----------------
Fix typo.
================
Comment at: clang/test/CodeGen/aix-builtin-mapping.c:5-6
+
+// RUN: %clang_cc1 -triple powerpc-ibm-aix -mlong-double-64 -S -o - %s |
FileCheck %s -check-prefix=CHECK
+// RUN: %clang_cc1 -triple powerpc64-ibm-aix -mlong-double-64 -S -o - %s |
FileCheck %s -check-prefix=CHECK
+
----------------
This should be an IR test. Checking assembly means actually needing the PowerPC
target enabled in the LLVM configuration.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137986/new/
https://reviews.llvm.org/D137986
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
