arichardson added inline comments.
Herald added a project: All.
================
Comment at: clang/lib/AST/ASTContext.cpp:11579
+unsigned ASTContext::getTargetAddressSpace(QualType T) const {
+ return T->isFunctionType() ? getTargetInfo().getProgramAddressSpace()
+ : getTargetAddressSpace(T.getQualifiers());
----------------
Can we add a DataLayout aware function to CodeGen instead? That would avoid the
need for getProgramAddressSpace() in TargetInfo?
================
Comment at: clang/lib/Basic/TargetInfo.cpp:153
MaxOpenCLWorkGroupSize = 1024;
+ ProgramAddrSpace = 0;
}
----------------
A bit late to this review (only just noticed it while merging) - but I don't
like that we end up duplicating even more DataLayout information here - while
it only affects AVR upstream, downstream CHERI and Morello have to duplicate
this to Arm/RISC-V/MIPS as well now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111566/new/
https://reviews.llvm.org/D111566
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
