cor3ntin added a comment. Thanks for working on this, it was fast! It looks good except for an issue with the diagnostic (which was partly pre-existing)
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9111-9115 def ext_operator_overload_static : ExtWarn< "declaring overloaded %0 as 'static' is a C++2b extension">, InGroup<CXXPre2bCompat>, DefaultIgnore; -def err_call_operator_overload_static : ExtWarn< +def err_future_operator_overload_static : ExtWarn< "declaring overloaded %0 as 'static' is a C++2b extension">, InGroup<CXX2b>; ---------------- Hum, I did not notice that before but this looks wrong. If I get that right, this is how it's usually done. ie it should not be `err_` (it's a warning) and in C++23 mode it's not an ExtWarn (which are turned into error in pendantic mode afaik). There are many similar patterns in the same file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138387/new/ https://reviews.llvm.org/D138387 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
