rengolin added a comment.
Hi Lei,
Thanks for the fix. A few comments. Also, please, add some tests.
cheers,
--renato
================
Comment at: lib/Driver/ToolChains.cpp:4266
@@ -4266,1 +4265,3 @@
+ if (Triple.isAndroid()) {
return Triple.isArch64Bit() ? "/system/bin/linker64" :
"/system/bin/linker";
+ } else if (Triple.isMusl()) {
----------------
This is an early return, no need for brackets not the "else" below. Ex:
if (Android)
return ...
if (musl) {
...
return ...
}
https://reviews.llvm.org/D22904
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
