klimek added a comment.

Generally, why do we need to have that much information? I.e. why do we need to 
know the exact type of the "requires" keyword?
I do understand we need to know the brace type, but that seems like it would be 
easier to figure out in the TokenAnnotator (where we already parsed 
UnwrappedLines).
Do we ever parse UnwrappedLines differently depending on requires 
clauses/expressions?
If not, we should really do the annotation in TokenAnnotator, where we already 
have nice parsing bounds from the parsed UnwrappedLines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119138/new/

https://reviews.llvm.org/D119138

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to