aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: clang/tools/c-index-test/c-index-test.c:1787 PrintCursor(cursor, NULL); + VisitorData *Data = (VisitorData *)d; PrintSingleTypeSize(T, " [type=%s] [typekind=%s]", " [sizeof=%lld]", ---------------- anderslanglands wrote: > anderslanglands wrote: > > aaron.ballman wrote: > > > I'm not super familiar with c-index-test -- how certain are you that the > > > client data will 1) be non-null, and 2) actually be a `VisitorData` > > > pointer? > > This was just copy-pasted from another function. I'm as certain as I can be > > given that all the tests pass :\ > From a quick scan, VisitorData is the only CXClientData struct used in the > visitor callbacks, so I think we're safe. Thanks! That matches what I was seeing as well, great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138377/new/ https://reviews.llvm.org/D138377 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
