jrtc27 added inline comments.
================ Comment at: clang/lib/Basic/Targets/RISCV.cpp:196 + // Currently we support the v0.10 RISC-V V intrinsics + unsigned Version = (0 * 1000000) + (10 * 1000); + Builder.defineMacro("__riscv_v_intrinsic", Twine(Version)); ---------------- Do we not have a function to do these (major, minor) -> integer encodings? I guess not since currently the only other instance is in the loop above. Might be worth factoring that out if we're going to grow more of these. ================ Comment at: clang/lib/Basic/Targets/RISCV.cpp:195 Builder.defineMacro("__riscv_vector"); + // Currently we support the v0.10 RISC-V V intrinsics + unsigned Version = (0 * 1000000) + (10 * 1000); ---------------- eopXD wrote: > asb wrote: > > Nit: comment should end with full stop. > Sorry I just landed the commit and missed this comment. May I ask what do yo > mean by full stop here? Do you mean a period? Full stop is British English for what is period in US English, yes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138930/new/ https://reviews.llvm.org/D138930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits