rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1917
+ EffectiveFieldSize = FieldSize = TI.Width;
+ FieldAlign = TI.Align;
} else {
----------------
arichardson wrote:
> arichardson wrote:
> > rjmccall wrote:
> > > This is a nice cleanup, but I actually can't figure out why we can't just
> > > fall into the code below.
> > It looks like this dates back to `Add a new ASTRecordLayoutBuilder class.
> > Not used yet.` from 2009. Maybe `ReferenceType`s were not handled correctly
> > by `Context.getTypeInfoInChars(RT);` back then?
> I've removed the special case now and it looks like all tests are passing, so
> I believe this is indeed no longer needed.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138295/new/
https://reviews.llvm.org/D138295
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
