HazardyKnusperkeks added a comment. In D139029#3961444 <https://reviews.llvm.org/D139029#3961444>, @HazardyKnusperkeks wrote:
> In D139029#3961438 <https://reviews.llvm.org/D139029#3961438>, @mairacanal > wrote: > >> In D139029#3961372 <https://reviews.llvm.org/D139029#3961372>, >> @HazardyKnusperkeks wrote: >> >>> Can you please add a test with more than one newline? >> >> Hi @HazardyKnusperkeks! Thanks for the feedback. It looks like >> `Changes[i].NewlinesBefore` values 1 even if I put multiple lines before the >> comment. Do you have any input on what could be causing this? From my point >> of view, it looks like the extra new lines are being removed before >> `alignTrailingComments` and then `Changes[i].NewlinesBefore = 1`, but I'm >> not really sure how to solve it. > > Try setting `MaxEmptyLinesToKeep` to a higher number. We can also use two additional test cases, with `MaxEmptyLinesToKeep` and without, always good to see that it works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139029/new/ https://reviews.llvm.org/D139029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
