craig.topper added a comment. In D139025#3961990 <https://reviews.llvm.org/D139025#3961990>, @eopXD wrote:
> In D139025#3961214 <https://reviews.llvm.org/D139025#3961214>, @jrtc27 wrote: > >> Should this live in RISCVISAInfo.h rather than be a Clang-specific thing >> given it's just for squeezing version info into the preprocessor? I can't >> think of a use for it outside that at the moment. > > This patch has the version value calculation in `RISCVISAInfo.h`, so sorry I > don't quite get what you mean. Do you mean specifically `__riscv_v_intrinsic` > macro? > > If you mean to have macro information under the `RISCVExtensionInfo`, I don't > see the need here as there are macro like `__riscv_v_min_vlen` that can be > implied by multiple macro-s. I think the suggestion was that it didn’t need to be in RISCVISAInfo.h because it is a never used outside of RISCV.cpp. So it could just be a static function in the cpp file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139025/new/ https://reviews.llvm.org/D139025 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
