nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: llvm/test/Bitcode/upgrade-annotation.ll:14 + +declare i32 @llvm.annotation.i32(i32, i8*, i8*, i32) +; CHECK: declare i32 @llvm.annotation.i32.p0i8(i32, i8*, i8*, i32) ---------------- arsenm wrote: > New tests should use opaque pointers. For autoupgrade we may want and need > both test copies I think this is fine for now. We'll deal with this when we remove the typed pointer auto-detection from the bitcode reader, at which point all existing typed pointer bitcode will get upgraded to opaque pointer bitcode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138722/new/ https://reviews.llvm.org/D138722 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
