hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Thanks. You can add a `Fix: https://github.com/llvm/llvm-project/issues/59147` in the commit message, it will automatically close the github issue when you commit the patch. ================ Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:144 + class $ambiguous^Y {}; + } + )cpp", ---------------- nit: merge the following line with this line, `})cpp"` ================ Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:152 + } + using ns::$explicit^Y; + )cpp", ---------------- nit: fix the alignment ================ Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:153 + using ns::$explicit^Y; + )cpp", + "^Y<int> x;"); ---------------- nit: and here as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
