tianshilei1992 added inline comments.
================ Comment at: openmp/libomptarget/DeviceRTL/src/Mapping.cpp:19 #pragma omp begin declare target device_type(nohost) - +extern const uint16_t __oclc_ABI_version; #include "llvm/Frontend/OpenMP/OMPGridValues.h" ---------------- jhuber6 wrote: > What if this isn't defined? We should be able to use the OpenMP library > without the AMD device libraries. Should it be extern weak? It should be put into AMD's `declare variant`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D139730 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
