Michael137 added inline comments.

================
Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7
 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s 
-O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s 
--check-prefixes=CHECK,CXX17
+// RUN: %clang_cc1 %std_cxx17- -dwarf-version=4 -gstrict-dwarf -triple x86_64 
%s -O0 -disable-llvm-passes -debug-info-kind=standalone -emit-obj -o - %s | 
llvm-dwarfdump --debug-info - | FileCheck %s --check-prefixes=DWARF-DUMP,STRICT
+// RUN: %clang_cc1 %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 
-disable-llvm-passes -debug-info-kind=standalone -emit-obj -o - %s | 
llvm-dwarfdump --debug-info - | FileCheck %s --check-prefixes=DWARF-DUMP,DWARFv4
----------------
aprantl wrote:
> aprantl wrote:
> > Michael137 wrote:
> > > chapuni wrote:
> > > > llvm-dwarfdump fails if x86 is unconfigured.
> > > I suppose we could just stop passing the triple explicitly
> > I think it would be better to check for the LLVM IR here, and add a second 
> > test that compiles that LLVM IR with llc in llvm/test/DebugInfo/X86
> Generally, no clang fronted tests should depend on any target to be 
> configured.
https://reviews.llvm.org/D140084


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139953/new/

https://reviews.llvm.org/D139953

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to