Michael137 added a comment. In D140084#3997123 <https://reviews.llvm.org/D140084#3997123>, @dblaikie wrote:
> Sorry, should've caught this in review. The clang change needs test coverage > in clang, but should verify the emitted it, rather than going all the way > down to object code. > > The llvm functionality is already tested (since it's just the flag on a > template parameter - it's not interesting to test that for different kinds of > templates if the flag handling is kind-agnostic anyway) I couldn't find any test inside `llvm/test` which verifies that `DW_AT_default_value` is being emitted correctly. Sure we don't need a test like that? > So instead of this could you adjust the existing clang test to verify IR > instead of dwarfdump? @dblaikie Isn't the clang test already doing that? In this test I mainly wanted to check that the `gstrict-dwarf` attribute works as expected. The IR will always have the default attribute attached to it, which the `clang/test/` already tests. But if this is redundant I don't mind just removing this test altogether Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140084/new/ https://reviews.llvm.org/D140084 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
