carlosgalvezp added a comment. In D139966#3999473 <https://reviews.llvm.org/D139966#3999473>, @njames93 wrote:
> I'm just a little uneasy with the description, this isn't "fixing" the linked > issue, its more a workaround. The issue itself is also a bit of a non-issue. Thanks for reviewing! The script has a shebang, whose purpose is to be able to launch it via "./add_new_check.py". Therefore as a user I expect that to work. As such, a supported use case was broken, so IMO the issue is valid, and this is a correct fix, not a workaround. The workaround is invoking the tool as "python3 add_new_check.py". If the intention is that people should invoke the script as "python3 add_new_check.py" always, instead of "./add_new_check.py", then it should not have any shebang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139966/new/ https://reviews.llvm.org/D139966 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
