jlebar added inline comments. ================ Comment at: lib/Driver/ToolChains.cpp:4773 @@ +4772,3 @@ + StringRef GpuArch = + DriverArgs.getLastArgValue(options::OPT_march_EQ, "sm_20"); + std::string LibDeviceFile = CudaInstallation.getLibDeviceFile(GpuArch); ---------------- I *think* march is never empty here. We should add it when we create the CudaActions.
Same below. If I'm right or if I'm wrong, let's make sure there are tests. :) ================ Comment at: test/Driver/cuda-detect.cu:66 @@ -63,2 +65,2 @@ // NOCUDAINC-NOT: "-include" "__clang_cuda_runtime_wrapper.h" // COMMON-SAME: "-x" "cuda" ---------------- Should we test the new sm_XX --> libdevice file mappings added? https://reviews.llvm.org/D23037 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
