foad added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3308
case Builtin::BI__builtin_isnormal: {
- // isnormal(x) --> x == x && fabsf(x) < infinity && fabsf(x) >= float_min
+ // isnormal(x) --> fabs(x) < infinity && !(fabs(x) < float_min)
CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E);
----------------
Why not make both compares ordered and write this as just `fabs(x) < infinity
&& fabs(x) >= float_min`? That seems conceptually simpler - i.e. it makes the
comment easier to understand and the IR no worse.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140294/new/
https://reviews.llvm.org/D140294
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
