aaron.ballman added inline comments.
================
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,4 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
- llvm::ArrayRef<SpecialMemberFunctionKind> SMFS, llvm::StringRef AndOr) {
+template <typename R>
+static std::string join(const R &SMFS, llvm::StringRef AndOr) {
----------------
I hadn't noticed this before -- why has this been converted to an unrestricted
template? If generality is what you were going for, it should have accepted a
range (or a pair of iterators) instead?
https://reviews.llvm.org/D23008
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
