dgoldman added inline comments.
================ Comment at: clang-tools-extra/clangd/ParsedAST.h:88 /// (These should be const, but RecursiveASTVisitor requires Decl*). - ArrayRef<Decl *> getLocalTopLevelDecls(); + ArrayRef<Decl *> getLocalTopLevelDecls() const; ---------------- kadircet wrote: > can you rather introduce a new overload that returns `ArrayRef<const Decl*>` Did you mean an overload with `ArrayRef<const Decl *> getLocalTopLevelDecls() const;`? ASTSignals gets a const ParsedAST &, unless you want me to const cast instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
