jcranmer-intel added a comment. Most of the testing for this change has been in conjunction with the changes in the SPIRV-LLVM-Translator repository here: https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/1799. I haven't updated the in-tree experimental target to support the target-extension types, but I did want to provide more documentation as to how these types work in the existing LLVM documentation for the SPIR-V backend.
There's still a few issues with this patch. First, I've made the use of these types unconditional for the SPIR-V target--it may be more appropriate to make these triggered off of a hidden option defaulted to off for now, or maybe based on whether or not opaque pointers are enabled. The other issue is the cast_image.cl test which... does an illegal operation in SPIR-V, and looking at the history of the test, doesn't seem to really test what it's claiming to test (https://reviews.llvm.org/D22927 was the revision it was adding tests for). I disabled the test for now for SPIR-V out of ignorance of which way to go about for fixing this test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141008/new/ https://reviews.llvm.org/D141008 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
