carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land.
LGTM, let's give @njames93 a few days in case he has some comments. ================ Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:258 + hasMethod(cxxMethodDecl(hasName("begin"), isConst())), + hasMethod(cxxMethodDecl(hasName("end"), + isConst())))))) // hasDeclaration ---------------- ccotter wrote: > ccotter wrote: > > carlosgalvezp wrote: > > > Replace tabs with spaces > > Ah, I think this was before I figured out `arc diff` and was copy/pasting > > diff files around :/ > > > > Thanks for catching this. > just to confirm, how did you notice the tabs? I couldnt find them when I > downloaded the phab raw diff for any of the versions in the history. I still > see a double right arrow `ยป` in the phab diff - is that indicating a tab or > something else? > > As a sanity check, I ran `./clang/tools/clang-format/git-clang-format > --binary build/bin/clang-format` from the root of my project and the tool did > not produce any changes with the latest version of the changes I submitted. You are right, it must be a bug in Phabricator! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits