smeenai accepted this revision.
smeenai added a comment.
@tamas' suggestion would be a good change to make IMO, but I think it's outside
the scope of this patch, and the patch as-is improves the status quo, so LGTM.
Is there any way to share the normalization logic between the two locations, or
does compiler-rt's CMake logic still need to be standalone?
================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:39
+ if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
+ set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER}
--target=${LLVM_RUNTIME_TRIPLE} -print-target-triple)
+ execute_process(COMMAND ${CXX_TARGET_TRIPLE}
----------------
Maybe something slightly more wordy like `NORMALIZE_TARGET_TRIPLE_COMMAND`
would be a clearer name?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140925/new/
https://reviews.llvm.org/D140925
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
