JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land.
If i'm reading this right, the change means we emit the same save-temps files as hip with the same naming convention. That sounds great, makes life easier for backend devs looking at either. I don't know why rdc is a factor - it's not obvious to me that it means anything on amdgpu - but if that's preserving hip's current handling it's fine by me. Thanks! ================ Comment at: clang/lib/Driver/Driver.cpp:4411 ++TCAndArch; } } ---------------- Why is rdc involved here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141440/new/ https://reviews.llvm.org/D141440 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits